aws / aws/aws-advanced-python-wrapper

Support for PyMySQL

オープン
#752 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る
enhancement
主要言語
Python
スター
98
フォーク
22
平均マージ
1日 9時間
マージ済み PR(30日)
5

説明

### Describe the feature

Support the usage of the pymysql connector

### Use Case

The project I'm working on uses pymysql, I tried to pass the `Connect` class to the `AwsWrapperConnection`, however, it's failing because it's casting the port argument to a `string`, even though I'm passing an `int`.

Code that's turning the port into a string:
```
def prepare_connect_info(self, host_info: HostInfo, props: Properties) -> Properties:
prop_copy: Properties = Properties(props.copy())

prop_copy["host"] = host_info.host

if host_info.is_port_specified():
prop_copy["port"] = str(host_info.port)

PropertiesUtils.remove_wrapper_props(prop_copy)
return prop_copy
```

pymysql code enforcing the int type:
`connections.py`
```
// ...
self.port = port or 3306
if type(self.port) is not int:
raise ValueError("port should be of type int")
// ...
```

I wonder if it's possible to remove that cast to string or adapt somehow to support pymysql. I'm not sure if that's all it's going to take, though.

### Proposed Solution

Remove the cast to string for the port
```
if host_info.is_port_specified():
prop_copy["port"] = host_info.port
```

or a condition for the pymysql library

### Other Information

_No response_

### Acknowledgements

- [ ] I may be able to implement this feature request
- [X] This feature might incur a breaking change

### The AWS Advanced Python Wrapper version used

1.1.1

### Python version used

3.12

### Operating System and version

Ubuntu 22.04

コントリビューションガイド

コントリビューションガイドを開く

調査の方向性

Start at prepare_connect_info and trace how its port property reaches the PyMySQL connections.py validation. Check the existing connection flow with an integer port and confirm that support works without breaking other connectors; done means a PyMySQL connection accepts the configured port.

索引モデルが issue の本文から書いたものです。

評価

技術スタック
mysql, python
領域
databases
issue の種類
機能追加
難易度
3/5
見積もり時間
1〜2日
活発さ
停滞
明瞭さ
おおむね明確
初心者へのやさしさ
45/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。