aws-samples / aws-samples/sample-autonomous-cloud-coding-agents

enhancement(registry): tighten adapter types, comments, and lifecycle coverage

オープン
#783 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る
enhancement registry
主要言語
TypeScript
スター
143
フォーク
46
平均マージ
3日 10時間
マージ済み PR(30日)
24

説明

## Context

Consolidated non-blocking clarity and coverage follow-ups from the final review of PR #779.

## Comment and documentation corrections

- Distinguish MCP `_meta` storage from SKILL `x-abca-runtime` frontmatter in the adapter header.
- Correct the claim that duplicate YAML keys are parser errors under `js-yaml` with `{ json: true }`; the emitter prevents key injection by quoting/escaping caller-controlled values.
- Include SKILL in the `resolve` path commentary.
- Clarify that `waitPastCreating` waits only until the record leaves `CREATING`, not until a terminal lifecycle state.
- Clarify that `autoApprove` gates only the final approval call; create and submit always occur.

## Type cleanup

- Evaluate a discriminated representation linking registry `kind` to its payload variant instead of a broad `kind: string` shape.
- Simplify `DeleteAttempt` to the states its consumers need, or document why all current states are valuable.

Keep any public `RegistryClient` port change separately reviewable and compatible with the architecture boundary.

## Coverage gap

Add a delete-lifecycle test proving `isComplete` rethrows a non-retryable, non-404 `GetRegistry` failure rather than treating it as absent or retryable.

## References

- PR #779
- `cdk/src/handlers/shared/registry/agent-registry-client.ts`
- `cdk/src/handlers/registry-provisioning/index.ts`

コントリビューションガイド

コントリビューションガイドを開く

調査の方向性

Read cdk/src/handlers/shared/registry/agent-registry-client.ts and cdk/src/handlers/registry-provisioning/index.ts, using PR #779 as context. Trace the delete lifecycle and the RegistryClient boundary before evaluating the type changes. Done means the comments are accurate, the adapter types reflect their consumers, and coverage proves non-retryable non-404 GetRegistry failures are rethrown.

索引モデルが issue の本文から書いたものです。

評価

技術スタック
typescript
領域
backend, testing
issue の種類
リファクタリング
難易度
4/5
見積もり時間
3〜5日
活発さ
活発
明瞭さ
おおむね明確
初心者へのやさしさ
48/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。