arrayfire / arrayfire/arrayfire-python

[Question] [Feature Request] __matmul__, Internal Type Hinting

Đang mở
#271 0 bình luận 0 reaction 0 người được giao Xem trên GitHub
Ngôn ngữ chính
Python
Star
422
Fork
63
Chỉ số merge pull request
Không có pull request nào được merge trong 30 ngày

Mô tả

I wanted to add support for @ operation in python. The \_\_matmult\_\_ operation, that's how it's overloaded, in the arrayfire.Array class.

It's a simple monkey patch on user code. But it'd be nice if it was official.

I went to my local source code and added it, but I wanted to start learning the internal more and maybe do some contribution. Just wondering if it's not redundant or unwanted.

I saw that the internal Python types aren't hinted properly.

The set_backend() takes a string, but that's primitive obsession. It should take a string litteral list.

from typing import Literal

backend: Literal["cuda", "opencl", "cpu"]

Or it should take an Enum.
And other functions.

or _clibrary_.get() returns a None. That's just due to Lazy Loading.

But a Typed Python interface could exist. Some wrapper python class might be needed so that the type of the exposed code is visible.

All of this would help learning by simply using the autocomplete features of the IDE or text editor.

I hope each backend offers at least some common interface. It should, as the goal of arrayfire is hardware agnostism.

So, every method should be discoverable by the linter at "code editing" time. Just put _ and __ if it's really private.

So get()._af_ wouldn't cause false linting errors.

Anyway, I might get into it if I have time. It seems like a nice contribution, and a nitpick of mine.

the typing package nd TYPE/CHECKING, and simple wrappers are quite powerful.

However, I know that you might not want to expose internal details at all, and so might have purposly not the type hinting of everything. But it's also possible that doing so is just a tedious boilerplate. I'd be fine with doing said tedious boilerplate to make it easier to use and understand.

So, if it's by choice that there isn't any type hinting and wrapper, then I won't do it. But If it's something you'd be interested in, I might do some work on it.

Also there was a bug with af.get_devicr_info(), it seems to give the default device, not active device. Tested it with my cpu graphics card and amd graphics card on arch linux. I'll edit this section once I'm back on my PC. (Away right now).

Hướng dẫn đóng góp

Chưa lập chỉ mục được hướng dẫn đóng góp cho kho mã nguồn này

Hướng nghiên cứu

Start by reviewing the Python bindings around arrayfire.Array, set_backend(), _clibrary_.get(), and af.get_devicr_info(), then inspect how existing public methods are exposed and tested. Clarify whether the project wants __matmul__, runtime wrappers, and static type hints before changing anything. Done means an agreed scope with consistent typing and verified behavior for the selected public API.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Đánh giá

Công nghệ
python
Lĩnh vực
api, developer-experience
Loại issue
Tính năng
Độ khó
5/5
Thời gian dự kiến
Hơn một tuần
Mức độ hoạt động
Đình trệ
Độ rõ ràng
Cần làm rõ
Mức phù hợp với người mới
25/100

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.