arduino / arduino/ArduinoCore-API
Feature Request - add "remote" member to the CanMsg class to denote Remote Transfer Request (RTR) frames
- 主要语言
- C++
- 星标
- 306
- 派生
- 150
- PR 合并指标
- 30 天内没有已合并 PR
描述
The CAN specification reserves a bit in the arbitration header to signal if the frame is a Remote Transfer Request (RTR) frame or a normal Data frame. This is the bit that follows the 11 identifier bits in the standard header, or the 18 bits of the second part of the identifier in an extended frame.
This is useful for system that use RTR (yes I know this is frowned on by some in the CAN community, see linked doc). However systems exist that require this support so we should enable the Uno R4 to detect if a frame has been sent with the RTR bit.
Given that the flag is already detected by the underlying FSP and the type appears in the "can_frame_t" CAN data frame struct, there is a relatively simple enhancement which I will float here.
The first part is to add it as a data member to the CanMsg class (in CanMsg.h)
```
uint32_t id;
uint8_t data_length;
uint8_t data[MAX_DATA_LENGTH];
bool remote; // == new member ==
```
and then add it to the constructors as an optional argument
```
class CanMsg : public Printable
// snip
CanMsg(uint32_t const can_id, uint8_t const can_data_len, uint8_t const * can_data_ptr, bool const remote_frame_type = false)
: id{can_id}
, data_length{min(can_data_len, MAX_DATA_LENGTH)}
, data{0}
, remote{remote_frame_type}
{
//snip
```
(It would also need to be copied across in the copy constructor and probably useful to emit it in the printTo function.)
This now makes it available, however it is always set to false so the msg will default as a data frame unless the flag is set when the object is created.
For incoming messages in the R4 Uno this occurs in the R7FA4M1_CAN.cpp file
```
void R7FA4M1_CAN::onCanCallback(can_callback_args_t * p_args)
{
switch (p_args->event)
{
case CAN_EVENT_TX_COMPLETE: break;
case CAN_EVENT_RX_COMPLETE: // Currently driver don't support this. This is unreachable code for now.
{
/* Extract the received CAN message. */
CanMsg const msg
(
(p_args->frame.id_mode == CAN_ID_MODE_STANDARD) ? CanStandardId(p_args->frame.id) : CanExtendedId(p_args->frame.id),
p_args->frame.data_length_code,
p_args->frame.data,
(p_args->frame.type == CAN_FRAME_TYPE_REMOTE) // == new argument ==
);
/* Store the received CAN message in the receive buffer. */
_can_rx_buf.enqueue(msg);
}
//snip
```
I have not considered whether this would also require a change to files related to other 32 bit Renases chips (most likely yes).
However it appears to be largely backwards compatible as it does not affect the id (the other option was to use bit 30 if the id).
So, looking for some feedback before I do any further work and potentially provide a PR.
/-------------------
https://copperhilltech.com/content/CiA%20802%20AN%20V1.0%20CANopen%20CAN%20remote%20frames%20%E2%80%93%20Avoiding%20of%20usage.pdf
贡献指南
这个仓库没有索引到贡献指南
调研方向
从 CanMsg.h 开始,跟踪构造函数、复制行为和 printTo 的输出,然后检查 R7FA4M1_CAN.cpp 以及 onCanCallback 对 can_frame_t 的处理。检查其他 32-bit Renesas CAN 文件是否需要相同的处理。完成的标准是:为已创建和已接收的消息保留 remote 状态,同时不破坏现有的构造路径。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- cpp
- 领域
- embedded-iot
- Issue 类型
- 功能
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 35/100