appsmithorg / appsmithorg/appsmith

[Feature] Form Field widget standardisation

オープン
#9,136 コメント 1 件 リアクション 1 件 担当者 5 名 @somangshu が担当を希望しています GitHub で見る
Enhancement Needs PRD Property Pane Query Widgets & IDE Pod UI Building Product Widget Property Widgets & Accelerators Pod Widgets Product
主要言語
TypeScript
スター
40.9k
フォーク
4.8k
平均マージ
1日 22時間
マージ済み PR(30日)
45

説明

### Is there an existing issue for this?

- [X] I have searched the existing issues

### Summary

Acheive predictable grouping and set of properties in all the Form field widgets

- [ ] Input Widget
- [ ] DatePicker Widget
- [ ] Switch Widget
- [ ] FilePicker Widget
- [ ] Select Widget
- [ ] Multi-select Widget
- [ ] Checkbox Widget
- [ ] RadioGroup Widget
- [ ] TreeSelect Widget
- [ ] Multi-TreeSelect Widget
- [ ] Audio Recorder Widget
- [ ] RichTextEditor Widget
- [ ] Rate Widget
- [ ] CheckboxGroup Widget

A few potential issues to note,
- [ ] Padding is inconsistent between CheckboxGroup and Checkbox Widget
- [x] Labels are only available in InputWidget, TreeSelect Widget, Multi Tree Select Widget
- [x] Position of labels are different in InputWidget and (Multi)TreeSelectWidget
- [x] Inconsistent popovers between Multi and Tree Select Widgets

Common list of properties in a general form field component
- [x] defaultValue
- [x] onChange/onValueChange
- [x] Label
- [x] onKeyPress
- [x] isVisible
- [x] isRequired
- [x] isDisabled
- [x] ValidationFn
- [x] Tooltip (Helper Text)
- [x] Tooltip (Error)
- [ ] onFocus
- [ ] onBlur
- [x] Label Styles and or field styles

### Why should this be worked on?

- [x] It is hard to consistently find properties as they lack predictable grouping
- [x] Some properties are missing in widgets, which should ideally have them
- [x] Alignment and such concerns arise if the padding and UI are not consistent

Screenshot 2021-11-12 at 3 08 28 PM

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。