appbaseio / appbaseio/reactivesearch

The headers are not being passed to request

Abierto
#1,536 8 comentarios 0 reacciones 1 asignado Asignado a @lakhansamani Ver en GitHub
bug good first issue :wave:
Lenguaje dominante
JavaScript
Estrellas
4.9k
Forks
478
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

In our app, we are passing customized headers to `initReactivesearch` and not seeing the customized headers being passed to the actual request. I think the reason is that the `headers` always got set to an empty object `{}` in this line https://github.com/appbaseio/appbase-js/blob/develop/src/core/index.js#L58.

Shouldn't this line be `this.headers = config.headers || {}`? otherwise any AppBase instance would always have an empty object in `headers`.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.