appbaseio / appbaseio/reactivesearch
The headers are not being passed to request
Offen
#1,536
8 Kommentare
0 Reaktionen
1 zugewiesene Person
Zugewiesen an @lakhansamani
Auf GitHub ansehen
bug
good first issue :wave:
- Vorherrschende Sprache
- JavaScript
- Sterne
- 4.9k
- Forks
- 478
- PR-Merge-Kennzahlen
- Keine gemergten PRs in 30 T.
Beschreibung
In our app, we are passing customized headers to `initReactivesearch` and not seeing the customized headers being passed to the actual request. I think the reason is that the `headers` always got set to an empty object `{}` in this line https://github.com/appbaseio/appbase-js/blob/develop/src/core/index.js#L58.
Shouldn't this line be `this.headers = config.headers || {}`? otherwise any AppBase instance would always have an empty object in `headers`.
Beitragsleitfaden
Bewertung
Dieses Issue wurde noch nicht bewertet.