appbaseio / appbaseio/reactivesearch

The headers are not being passed to request

Open
#1,536 8 comments 0 reactions 1 assignee Assigned to @lakhansamani View on GitHub
bug good first issue :wave:
Dominant language
JavaScript
Stars
4.9k
Forks
478
PR merge metrics
No merged PRs in 30d

Description

In our app, we are passing customized headers to `initReactivesearch` and not seeing the customized headers being passed to the actual request. I think the reason is that the `headers` always got set to an empty object `{}` in this line https://github.com/appbaseio/appbase-js/blob/develop/src/core/index.js#L58.

Shouldn't this line be `this.headers = config.headers || {}`? otherwise any AppBase instance would always have an empty object in `headers`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.