apolloconfig / apolloconfig/apollo

upgrade junit to 5 or not?

Aperta
#4,195 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
area/test discussion
Lingua principale
Java
Stelle
29.8k
Fork
10.2k
Merge medio
4g 7h
PR unite (30g)
4

Descrizione

**Is your feature request related to a problem? Please describe.**

Does need to upgrade junit 4 to junit 5?

See #4193 if we upgrade the project's test to junit 5, some test feature like `@Nested` annotation can be used.

**Describe the solution you'd like**
* change the maven dependencies
* change the import in java code
* change the ci

**Additional context**

awaitility use junit 4, see
https://github.com/apolloconfig/apollo/blob/master/pom.xml#L282-L285
```java

org.awaitility
awaitility
test

```
We need to investigate that awaitility can use junit 5 or not.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.