apolloconfig / apolloconfig/apollo

upgrade junit to 5 or not?

Abierto
#4,195 1 comentario 0 reacciones 0 asignados Ver en GitHub
area/test discussion
Lenguaje dominante
Java
Estrellas
29.8k
Forks
10.2k
Merge medio
4 d 7 h
PR fusionados (30 d)
4

Descripción

**Is your feature request related to a problem? Please describe.**

Does need to upgrade junit 4 to junit 5?

See #4193 if we upgrade the project's test to junit 5, some test feature like `@Nested` annotation can be used.

**Describe the solution you'd like**
* change the maven dependencies
* change the import in java code
* change the ci

**Additional context**

awaitility use junit 4, see
https://github.com/apolloconfig/apollo/blob/master/pom.xml#L282-L285
```java

org.awaitility
awaitility
test

```
We need to investigate that awaitility can use junit 5 or not.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.