Accept local timestamps annotated with the legacy timestamp types
- 主要言語
- Java
- スター
- 3.1k
- フォーク
- 1.6k
- 平均マージ
- 3日 12時間
- マージ済み PR(30日)
- 33
説明
The rules for TIMESTAMP forward-compatibility were created based on the assumption that TIMESTAMP_MILLIS and TIMESTAMP_MICROS have only been used in the instant aka. UTC-normalized semantics so far.
From this false premise it followed that TIMESTAMPs with local semantics were a new type and did not need to be annotated with the old types to maintain compatibility. In fact, annotating them with the old types were considered to be harmful, since it would have mislead older readers into thinking that they can read TIMESTAMPs with local semantics, when in reality they would have misinterpreted them as TIMESTAMPs with instant semantics. This would have lead to a difference of several hours, corresponding to the time zone offset.
In reality, however, this misinterpretation of timestamps has already been going on for a while, since Arrow annotates local timestamps with TIMESTAMP_MILLIS or TIMESTMAP_MICROS.
To maintain forward compatibilty of local timestamps, Arrow annotates them with the legacy timestamp logical types. However, the Java library considers these logical types to be incompatible and discards the new type in favour of the legacy ones (since doing the other way around would change the behaviour). Parquet-mr should be updated so that it accepts this combination of new and old logical types.
**Reporter**: [Zoltan Ivanfi](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=zi) / @zivanfi
**Assignee**: [Nándor Kollár](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=nkollar) / @nandorKollar
#### PRs and other links:
- [Discussion on the mailing list](https://lists.apache.org/thread.html/04b9a8a156939adae1aa4cf2d4e3abd2137f541cbf92ade6d775dc06@%3Cdev.parquet.apache.org%3E)
**Note**: *This issue was originally created as [PARQUET-1628](https://issues.apache.org/jira/browse/PARQUET-1628). Please see the [migration documentation](https://issues.apache.org/jira/browse/PARQUET-2502) for further details.*
コントリビューションガイド
このリポジトリのコントリビューションガイドは索引されていません
調査の方向性
まず issue とリンクされているメーリングリストの議論を読み、その後、parquet-java による timestamp 論理型の処理と、Java ライブラリの互換性チェックを追跡してください。TIMESTAMP_MILLIS または TIMESTAMP_MICROS でアノテーションされた Arrow のローカル timestamp についての動作を確認してください。この組み合わせが新しい型を破棄せずに受け入れられれば、完了とします。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- java
- 領域
- data-engineering
- issue の種類
- バグ
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 活発さ
- 停滞
- 明瞭さ
- おおむね明確
- 初心者へのやさしさ
- 35/100