apache / apache/libcloud

DNSPodDNSTests.test_create_record_success() returns an unexpected value

Abierto
#1,538 1 comentario 0 reacciones 0 asignados Ver en GitHub
stale
Lenguaje dominante
Python
Estrellas
2.1k
Forks
931
Merge medio
1 d 2 h
PR fusionados (30 d)
4

Descripción

## `DNSPodDNSTests.test_create_record_success()` returns an unexpected value

Consider the following code (in [test_dnspod.py](https://github.com/apache/libcloud/blob/6b588346083a510396c63b5d18db3012aa083071/libcloud/test/dns/test_dnspod.py#L156)):

def test_create_record_success(self):
DNSPodMockHttp.type = 'CREATE_RECORD_SUCCESS'
record = self.driver.create_record(name='@', zone=self.test_zone,
type='A', data='96.126.115.73',
extra={'ttl': 13,
'record_line': 'default'})

## Expected result

I would expect `record.extra['ttl']` to be an int 13

## Actual result

The actual result, when running this unit test is:

`record.extra['ttl']` is the string `'600'`.
`record.ttl` is `None`.

Note that `'600'` (yes, a string) is the default TTL of the `self.test_zone`. [See the explicit check in line 61](https://github.com/apache/libcloud/blob/6b588346083a510396c63b5d18db3012aa083071/libcloud/test/dns/test_dnspod.py#L61).

## Detailed Information

At first, I expected an error in `DNSPodDNSDriver.create_record()`. Perhaps it ignored the `extra` parameter.

However, the `extra` dict is merged in the `data` dict, which is send to the DNSPod API, so that seems correct (although I don't know the intrinsics of the DNSPod API can am not sure).

Diving deeper in the test code, the perhaps likely explanation is that the API simulator (DNSPodMockHttp) returns the incorrect results. `DNSPodMockHttp._Record_Create_CREATE_RECORD_SUCCESS()` is called, which returns the contents of [`get_record.json`](https://github.com/apache/libcloud/blob/trunk/libcloud/test/dns/fixtures/dnspod/get_record.json). That file indeed contains `"ttl": "600",`. So I suspect that the unit test is flawed, not the actual code or DNSPod API (although I can't verify without access to this API).

## Suggested Fix

Without a contributor who has access to this API, my suggested solution is to disable this particular assertion in `DNSPodDNSTests.test_create_record_success()`.

This fix is included in #1537

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Comienza con libcloud/test/dns/test_dnspod.py, especialmente con DNSPodDNSTests.test_create_record_success(), e inspecciona la ruta de respuesta de DNSPodMockHttp y libcloud/test/dns/fixtures/dnspod/get_record.json. Ejecuta la prueba específica y compara el TTL del fixture con los campos de registro esperados por la prueba; determina si la assertion o el fixture deberían representar el comportamiento de la API, teniendo en cuenta la corrección sugerida en issue #1537.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
python
Área
api, testing-qa
Tipo de issue
Error
Dificultad
2/5
Tiempo estimado
1-3 horas
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.