apache / apache/libcloud

DNSPodDNSTests.test_create_record_success() returns an unexpected value

Offen
#1,538 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
stale
Vorherrschende Sprache
Python
Sterne
2.1k
Forks
931
Ø Merge
1 T. 2 Std.
Gemergte PRs (30 T.)
4

Beschreibung

## `DNSPodDNSTests.test_create_record_success()` returns an unexpected value

Consider the following code (in [test_dnspod.py](https://github.com/apache/libcloud/blob/6b588346083a510396c63b5d18db3012aa083071/libcloud/test/dns/test_dnspod.py#L156)):

def test_create_record_success(self):
DNSPodMockHttp.type = 'CREATE_RECORD_SUCCESS'
record = self.driver.create_record(name='@', zone=self.test_zone,
type='A', data='96.126.115.73',
extra={'ttl': 13,
'record_line': 'default'})

## Expected result

I would expect `record.extra['ttl']` to be an int 13

## Actual result

The actual result, when running this unit test is:

`record.extra['ttl']` is the string `'600'`.
`record.ttl` is `None`.

Note that `'600'` (yes, a string) is the default TTL of the `self.test_zone`. [See the explicit check in line 61](https://github.com/apache/libcloud/blob/6b588346083a510396c63b5d18db3012aa083071/libcloud/test/dns/test_dnspod.py#L61).

## Detailed Information

At first, I expected an error in `DNSPodDNSDriver.create_record()`. Perhaps it ignored the `extra` parameter.

However, the `extra` dict is merged in the `data` dict, which is send to the DNSPod API, so that seems correct (although I don't know the intrinsics of the DNSPod API can am not sure).

Diving deeper in the test code, the perhaps likely explanation is that the API simulator (DNSPodMockHttp) returns the incorrect results. `DNSPodMockHttp._Record_Create_CREATE_RECORD_SUCCESS()` is called, which returns the contents of [`get_record.json`](https://github.com/apache/libcloud/blob/trunk/libcloud/test/dns/fixtures/dnspod/get_record.json). That file indeed contains `"ttl": "600",`. So I suspect that the unit test is flawed, not the actual code or DNSPod API (although I can't verify without access to this API).

## Suggested Fix

Without a contributor who has access to this API, my suggested solution is to disable this particular assertion in `DNSPodDNSTests.test_create_record_success()`.

This fix is included in #1537

Beitragsleitfaden

Beitragsleitfaden öffnen

Rechercherichtung

Beginne mit libcloud/test/dns/test_dnspod.py, insbesondere mit DNSPodDNSTests.test_create_record_success(), und untersuche den Antwortpfad von DNSPodMockHttp sowie libcloud/test/dns/fixtures/dnspod/get_record.json. Führe den fokussierten Test aus und vergleiche den TTL-Wert des Fixtures mit den erwarteten Record-Feldern des Tests; bestimme, ob die Assertion oder das Fixture das API-Verhalten abbilden sollte, und berücksichtige den in issue #1537 vorgeschlagenen Fix.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
python
Bereich
api, testing-qa
Issue-Typ
Bug
Schwierigkeit
2/5
Geschätzter Aufwand
1-3 Stunden
Aktivitätsstatus
Veraltet
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
35/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.