apache / apache/datasketches-cpp

Reorganization proposal

未关闭
#419 6 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
C++
星标
273
派生
88
平均合并
2 天 2 小时
30 天内合并 PR
8

描述

Hi there,

We are consider using datasketches in our C++ environment. The current organization, where there a bunch of folders, each with an `include/` directory, is a bit awkward for integrating into a foreign build system. Projects like [pybind11](https://github.com/pybind/pybind11/) put all of the headers in a single `include/` directory (perhaps with subdirectories underneath). Then there is just a single path to add as an include path.

Would you be open to a reorganization that moved around files to look a bit like this:
```
include/datasketches
count/
count_min.hpp
count_min_impl.hpp
common/
MurmurHash3.h
...
```

Thanks for your consideration.

贡献指南

打开贡献指南

调研方向

检查 repository 现有的组件文件夹及其 include/ 目录,然后将它们与提议的 include/datasketches 布局以及 issue 中链接的 pybind11 先例进行比较。在更改文件之前,确认 maintainer 已就目标组织方式达成一致;只有存在一个能为外部构建系统提供单一 include 路径的已接受布局,才算完成。

由索引模型根据 Issue 内容生成。

评估

技术栈
cpp
领域
build-system
Issue 类型
重构
难度
5/5
预计耗时
一周以上
活跃度
停滞
描述清晰度
需要澄清
新手友好度
20/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。