apache / apache/datafusion-sqlparser-rs

Parse data types based on current dialect

Open
#623 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
3.5k
Forks
772
Avg merge
4d 9h
Merged PRs (30d)
17

Description

Currently we parse data types ignoring the dialect, which doesn't make that much sense. This requires the caller to validate not only their usage, but if we parsed the data types correctly.

Could we add the dialect to parse the data types? That's done in a few parts of the code using `dialect_of!()`

Contributor guide

No contributing guide indexed for this repository

Research direction

Locate the data type parsing entry points and the existing uses of `dialect_of!()` mentioned in the issue. Trace how the current dialect reaches related parser code, then verify that data types are parsed with that dialect and that the existing parser tests cover dialect-specific behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.