apache / apache/datafusion-sqlparser-rs

PostgreSQL 18 generated virtual columns require STORED

Aperta Adatta ai principianti
#2,407 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Rust
Stelle
3.5k
Fork
772
Merge medio
4g 9h
PR unite (30g)
17

Descrizione

## Summary

`PostgreSqlDialect` rejects PostgreSQL 18 generated columns when the generated-column mode is omitted.

PostgreSQL 18 supports both stored and virtual generated columns. Per the PostgreSQL 18 docs, generated columns are virtual by default and `VIRTUAL` / `STORED` are optional explicit mode keywords:

https://www.postgresql.org/docs/current/ddl-generated-columns.html

## Reproduction

Using `sqlparser` 0.62.0 with `PostgreSqlDialect`, parse:

```sql
CREATE TABLE users (
first_name text NOT NULL,
last_name text NOT NULL,
name character varying(255)
GENERATED ALWAYS AS (((first_name || ' '::text) || last_name))
NOT NULL
);
```

## Expected behavior

The statement parses successfully, with `name` represented as a generated virtual column. Since PostgreSQL 18 defaults generated columns to virtual, omitted mode should be accepted as virtual or at least accepted with no explicit mode.

## Actual behavior

Parsing fails with:

```text
sql parser error: Expected: STORED, found: NOT
```

This also affects PostgreSQL 18 `pg_dump` output, which emits generated virtual columns without an explicit `VIRTUAL` keyword, for example:

```sql
name character varying(255) GENERATED ALWAYS AS (((first_name || ' '::text) || last_name)) NOT NULL
```

## Notes

`GenericDialect` can parse a variant when `VIRTUAL` is made explicit, but `PostgreSqlDialect` currently appears to require `STORED` after `GENERATED ALWAYS AS (...)`.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Direzione di ricerca

Start at the PostgreSqlDialect handling for generated columns and reproduce the supplied CREATE TABLE statement with an omitted mode. Ensure PostgreSQL 18 virtual generated columns are accepted, then add or run regression coverage showing that the statement parses successfully without requiring STORED.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
postgresql, rust
Ambito
databases
Tipo di issue
Bug
Difficoltà
2/5
Tempo stimato
1-3 ore
Stato di attività
Tranquilla
Chiarezza
Abbastanza chiara
Idoneità per principianti
73/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.