apache / apache/datafusion-sqlparser-rs

PostgreSQL 18 generated virtual columns require STORED

Offen Anfängerfreundlich
#2,407 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
Rust
Sterne
3.5k
Forks
772
Ø Merge
4 T. 9 Std.
Gemergte PRs (30 T.)
17

Beschreibung

## Summary

`PostgreSqlDialect` rejects PostgreSQL 18 generated columns when the generated-column mode is omitted.

PostgreSQL 18 supports both stored and virtual generated columns. Per the PostgreSQL 18 docs, generated columns are virtual by default and `VIRTUAL` / `STORED` are optional explicit mode keywords:

https://www.postgresql.org/docs/current/ddl-generated-columns.html

## Reproduction

Using `sqlparser` 0.62.0 with `PostgreSqlDialect`, parse:

```sql
CREATE TABLE users (
first_name text NOT NULL,
last_name text NOT NULL,
name character varying(255)
GENERATED ALWAYS AS (((first_name || ' '::text) || last_name))
NOT NULL
);
```

## Expected behavior

The statement parses successfully, with `name` represented as a generated virtual column. Since PostgreSQL 18 defaults generated columns to virtual, omitted mode should be accepted as virtual or at least accepted with no explicit mode.

## Actual behavior

Parsing fails with:

```text
sql parser error: Expected: STORED, found: NOT
```

This also affects PostgreSQL 18 `pg_dump` output, which emits generated virtual columns without an explicit `VIRTUAL` keyword, for example:

```sql
name character varying(255) GENERATED ALWAYS AS (((first_name || ' '::text) || last_name)) NOT NULL
```

## Notes

`GenericDialect` can parse a variant when `VIRTUAL` is made explicit, but `PostgreSqlDialect` currently appears to require `STORED` after `GENERATED ALWAYS AS (...)`.

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Rechercherichtung

Start at the PostgreSqlDialect handling for generated columns and reproduce the supplied CREATE TABLE statement with an omitted mode. Ensure PostgreSQL 18 virtual generated columns are accepted, then add or run regression coverage showing that the statement parses successfully without requiring STORED.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
postgresql, rust
Bereich
databases
Issue-Typ
Bug
Schwierigkeit
2/5
Geschätzter Aufwand
1-3 Stunden
Aktivitätsstatus
Ruhig
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
73/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.