[JAVA] flight-sql-jdbc-driver V16.0.0 shading relocates slf4j dependency
- 主要語言
- Java
- 星號
- 94
- 分支
- 152
- 平均合併
- 3 天 16 小時
- 30 天內合併 PR
- 11
描述
### Describe the bug, including details regarding any error messages, version, and platform.
When I upgrade to version 16.0.0, suddenly my @Slf4j annotation did no longer work. When I checked for manually creating a LoggerFactory, I noticed that the only imports Intellj could find were unter the path of:
import org.apache.arrow.driver.jdbc.shaded.*;
I then checked the pom.xml of the flight-sql-jdbc-driver and noticed the shading relocations you configured:
https://github.com/apache/arrow/blob/7cd9c6fbd313c9afa0673d85415a84fd199951c9/java/flight/flight-sql-jdbc-driver/pom.xml#L98
```
com.
org.apache.arrow.driver.jdbc.shaded.com.
com.sun.**
org.
org.apache.arrow.driver.jdbc.shaded.org.
org.apache.arrow.driver.jdbc.**
org.apache.arrow.flight.name
org.apache.arrow.flight.version
org.apache.arrow.flight.jdbc-driver.name
org.apache.arrow.flight.jdbc-driver.version
```
I am not an expert on the shading plugin of maven, but it seems to me it moves around all dependencies below the com. and org. pattern. Even if I exclude those dependencies from the flight-sql-jdbc-driver, it does not help.
If I go down to version 15.x.x it works again.
### Component(s)
Java
貢獻指南
研究方向
從 java/flight/flight-sql-jdbc-driver/pom.xml 中 issue 所連結的 shading relocation 附近開始,並將 16.0.0 的設定與 15.x.x 版本進行比較。檢查 com. 和 org. 模式如何影響 SLF4J 以及 @Slf4j imports。完成的標準是:driver 不再意外地 relocation 面向使用者的 logging dependency,同時保留其預期的 shading。
由索引模型根據 Issue 內容生成。
評估
- 技術堆疊
- java
- 領域
- build-system
- Issue 類型
- 缺陷
- 難度
- 3/5
- 預估耗時
- 1-2 天
- 活躍度
- 停滯
- 描述清晰度
- 基本清楚
- 新手友好度
- 35/100