apache / apache/arrow-java

[JAVA] flight-sql-jdbc-driver V16.0.0 shading relocates slf4j dependency

未关闭
#91 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Java
星标
94
派生
152
平均合并
3 天 16 小时
30 天内合并 PR
11

描述

### Describe the bug, including details regarding any error messages, version, and platform.

When I upgrade to version 16.0.0, suddenly my @Slf4j annotation did no longer work. When I checked for manually creating a LoggerFactory, I noticed that the only imports Intellj could find were unter the path of:
import org.apache.arrow.driver.jdbc.shaded.*;

I then checked the pom.xml of the flight-sql-jdbc-driver and noticed the shading relocations you configured:

https://github.com/apache/arrow/blob/7cd9c6fbd313c9afa0673d85415a84fd199951c9/java/flight/flight-sql-jdbc-driver/pom.xml#L98

```

com.
org.apache.arrow.driver.jdbc.shaded.com.

com.sun.**

org.
org.apache.arrow.driver.jdbc.shaded.org.

org.apache.arrow.driver.jdbc.**
org.apache.arrow.flight.name
org.apache.arrow.flight.version
org.apache.arrow.flight.jdbc-driver.name
org.apache.arrow.flight.jdbc-driver.version

```

I am not an expert on the shading plugin of maven, but it seems to me it moves around all dependencies below the com. and org. pattern. Even if I exclude those dependencies from the flight-sql-jdbc-driver, it does not help.

If I go down to version 15.x.x it works again.

### Component(s)

Java

贡献指南

打开贡献指南

调研方向

从 java/flight/flight-sql-jdbc-driver/pom.xml 中 issue 所链接的 shading relocation 附近开始,并将 16.0.0 的配置与 15.x.x 版本进行比较。检查 com. 和 org. 模式如何影响 SLF4J 以及 @Slf4j imports。完成的标准是:driver 不再意外地 relocation 面向用户的 logging dependency,同时保留其预期的 shading。

由索引模型根据 Issue 内容生成。

评估

技术栈
java
领域
build-system
Issue 类型
缺陷
难度
3/5
预计耗时
1-2 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
35/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。