apache / apache/arrow-java

[Java][Release] Checkstyle plugin fails on ORC log4j.properties files

オープン
#381 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る
Type: bug
主要言語
Java
スター
94
フォーク
152
平均マージ
3日 16時間
マージ済み PR(30日)
11

説明

```Java

[INFO] --- maven-checkstyle-plugin:3.1.0:check (validate) @ arrow-orc ---
[INFO] Starting audit...
[WARNING] ../../../cpp/java-build/orc_ep-prefix/src/orc_ep/java/bench/core/src/resources/log4j.properties:[1] (misc) NewlineAtEndOfFile: File does not end with a newline. [2/13566]
[WARNING] ../../../cpp/java-build/orc_ep-prefix/src/orc_ep/java/bench/core/src/resources/log4j.properties:[1] (header) Header: Line does not match expected header line of '/*'.
[WARNING] ../../../cpp/java-build/orc_ep-prefix/src/orc_ep/java/tools/src/test/resources/log4j.properties:[1] (misc) NewlineAtEndOfFile: File does not end with a newline.
[WARNING] ../../../cpp/java-build/orc_ep-prefix/src/orc_ep/java/tools/src/test/resources/log4j.properties:[1] (header) Header: Line does not match expected header line of '/*'.
[WARNING] ../../../cpp/java-build/orc_ep-prefix/src/orc_ep/java/core/src/test/resources/log4j.properties:[1] (misc) NewlineAtEndOfFile: File does not end with a newline.
[WARNING] ../../../cpp/java-build/orc_ep-prefix/src/orc_ep/java/core/src/test/resources/log4j.properties:[1] (header) Header: Line does not match expected header line of '/*'.
[WARNING] ../../../cpp/java-build/orc_ep-prefix/src/orc_ep/java/shims/src/test/resources/log4j.properties:[1] (misc) NewlineAtEndOfFile: File does not end with a newline.
[WARNING] ../../../cpp/java-build/orc_ep-prefix/src/orc_ep/java/shims/src/test/resources/log4j.properties:[1] (header) Header: Line does not match expected header line of '/*'.
[WARNING] ../../../cpp/java-build/orc_ep-prefix/src/orc_ep/java/mapreduce/src/test/resources/log4j.properties:[1] (misc) NewlineAtEndOfFile: File does not end with a newline.
[WARNING] ../../../cpp/java-build/orc_ep-prefix/src/orc_ep/java/mapreduce/src/test/resources/log4j.properties:[1] (header) Header: Line does not match expected header line of '/*'.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Apache Arrow Java Root POM 4.0.0 ................... SUCCESS [ 20.941 s]
[INFO] Arrow Format ....................................... SUCCESS [ 13.575 s]
[INFO] Arrow Memory ....................................... SUCCESS [ 3.421 s]
[INFO] Arrow Memory - Core ................................ SUCCESS [ 23.079 s]
[INFO] Arrow Memory - Unsafe .............................. SUCCESS [ 8.857 s]
[INFO] Arrow Memory - Netty ............................... SUCCESS [ 12.396 s]
[INFO] Arrow Vectors ...................................... SUCCESS [05:25 min]
[INFO] Arrow Compression .................................. SUCCESS [ 13.225 s]
[INFO] Arrow Tools ........................................ SUCCESS [ 58.561 s]
[INFO] Arrow JDBC Adapter ................................. SUCCESS [ 18.186 s]
[INFO] Arrow Plasma Client ................................ SUCCESS [ 9.206 s]
[INFO] Arrow Flight Core .................................. SUCCESS [01:43 min]
[INFO] Arrow Flight GRPC .................................. SUCCESS [ 13.424 s]
[INFO] Arrow AVRO Adapter ................................. SUCCESS [ 25.145 s]
[INFO] Arrow Algorithms ................................... SUCCESS [ 46.659 s]
[INFO] Arrow Performance Benchmarks ....................... SUCCESS [ 10.682 s]
[INFO] Arrow Orc Adapter .................................. FAILURE [ 0.319 s]
[INFO] Arrow Gandiva ...................................... SKIPPED
[INFO] Arrow Java Dataset 4.0.0 ........................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 11:47 min
[INFO] Finished at: 2021-04-26T21:33:31+02:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0:check (validate) on project arrow-orc: You have 10 Checkstyle violations. -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn -rf :arrow-orc
```

As a workaround I can skip checkstyle checks using `-Dcheckstyle.skip=true`

**Reporter**: [Krisztian Szucs](https://issues.apache.org/jira/browse/ARROW-12552) / @kszucs

**Note**: *This issue was originally created as [ARROW-12552](https://issues.apache.org/jira/browse/ARROW-12552). Please see the [migration documentation](https://github.com/apache/arrow/issues/14542) for further details.*

コントリビューションガイド

コントリビューションガイドを開く

調査の方向性

cpp/java-build/orc_ep-prefix/src/orc_ep/java 配下の ORC log4j.properties ファイルで失敗が報告されています。bench/core/src/resources、および core、shims、tools、mapreduce のテストリソースが含まれます。まず arrow-orc の checkstyle 検証がこれらのファイルをどのように処理するかを調べ、次に :arrow-orc で Maven ビルドを再開し、報告された 10 件の違反が解決されていることを確認してください。

索引モデルが issue の本文から書いたものです。

評価

技術スタック
java
領域
build-system
issue の種類
バグ
難易度
2/5
見積もり時間
1〜3時間
活発さ
停滞
明瞭さ
おおむね明確
初心者へのやさしさ
35/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。