apache / apache/arrow-java

[Java] Adapt to Java 9/9+ automatic module system

Ouverte
#379 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Type: enhancement
Langage dominant
Java
Étoiles
94
Forks
152
Merge moyen
3 j 16 h
PR mergées (30 j)
11

Description

In Java 9/9+, within following module-info.java definition the build will fail by error:

```Java

module my.app {
exports my.app;

requires arrow.memory.core;
requires arrow.memory.unsafe;
}
```

The error:
> java: the unnamed module reads package org.apache.arrow.memory from both arrow.memory.core and arrow.memory.unsafe

It seems that JPMS requires a package to be read from at most one individual module. Ref: http://openjdk.java.net/projects/jigsaw/spec/sotms/#the-module-path. If so what we may have to do is to conduct a code clean up for our maven modules to make sure we don't populate codes in the same package into different libraries.

Also, as a more standardized practice, it's might be an option to put entries with name **Automatic-Module-Name** into manifest files to tell automatic module system to generate predefined module names rather than parsing from jar file name. Ref: https://docs.oracle.com/javase/9/docs/api/java/lang/module/ModuleFinder.html#automatic-modules

Note that it's not a goal for this topic to migrate to Java 9/9+.

**Reporter**: [Hongze Zhang](https://issues.apache.org/jira/browse/ARROW-12905) / @zhztheplayer

**Note**: *This issue was originally created as [ARROW-12905](https://issues.apache.org/jira/browse/ARROW-12905). Please see the [migration documentation](https://github.com/apache/arrow/issues/14542) for further details.*

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

Start with the module-info.java example and the Maven modules that provide org.apache.arrow.memory, then review the linked migration documentation and JPMS references. Check how packages are split between arrow.memory.core and arrow.memory.unsafe and how manifest files are produced. Done means the duplicate-package failure is addressed and automatic module names are defined where appropriate without migrating the project to Java 9+.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
java
Domaine
build-system
Type d'issue
Refactorisation
Difficulté
5/5
Temps estimé
Plus d'une semaine
Activité
À l'abandon
Clarté
À clarifier
Accessibilité débutants
20/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.