[Java] JDBC to Arrow converter iterator should reuse the same VectorSchemaRoot
- Dominant language
- Java
- Stars
- 94
- Forks
- 152
- Avg merge
- 3d 16h
- Merged PRs (30d)
- 11
Description
When originally reviewing the code I suggested a new VectorSchemaRoot on each call to the iterator. After further discussions on the mailing list, it seems that this is an anit-pattern for working with VectorSchemaRoot, we should update the code to update a single VectorSchemaRoot.
After this change it should be easier to use JDBC converter with other components of the library (i.e. filewriter) which also make use of a single VectorSchemaRoot.
**Reporter**: [Micah Kornfield](https://issues.apache.org/jira/browse/ARROW-9614) / @emkornfield
**Note**: *This issue was originally created as [ARROW-9614](https://issues.apache.org/jira/browse/ARROW-9614). Please see the [migration documentation](https://github.com/apache/arrow/issues/14542) for further details.*
Contributor guide
Research direction
Start by locating the Java JDBC converter's iterator and compare its VectorSchemaRoot handling with the filewriter components mentioned in the issue. Confirm how the iterator currently creates roots and identify any related tests. Done means the converter reuses one VectorSchemaRoot and works with components that expect a single root.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- databases
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100