[Java][FlightSQL] JDBC driver returns pre-1970 dates one day late when a Calendar is supplied
- 主要言語
- Java
- スター
- 94
- フォーク
- 152
- 平均マージ
- 3日 16時間
- マージ済み PR(30日)
- 11
説明
### Describe the bug, including details regarding any error messages, version, and platform.
`DateTimeUtils.getTimestampValue(long)` splits epoch milliseconds into an epoch day and a time within that day. The old code used `/` and `%`:
```java
public static Timestamp getTimestampValue(long millisWithCalendar) {
long milliseconds = millisWithCalendar;
if (milliseconds < 0) {
// LocalTime#ofNanoDay only accepts positive values
milliseconds -= ((milliseconds / MILLIS_PER_DAY) - 1) * MILLIS_PER_DAY;
}
return Timestamp.valueOf(
LocalDateTime.of(
LocalDate.ofEpochDay(millisWithCalendar / MILLIS_PER_DAY),
LocalTime.ofNanoOfDay(TimeUnit.MILLISECONDS.toNanos(milliseconds % MILLIS_PER_DAY))));
}
```
Both operators round toward zero. For dates before 1970, the code adjusted the negative remainder because `LocalTime.ofNanoOfDay` rejects it. It did not adjust the epoch day. When the input was negative and not exactly midnight, the day and remainder then referred to different days. The date came back one day late.
For example, `-618102000000` ms is 1950-06-01 01:00:00 UTC. Division by `86400000` truncates to `-7153`, which is 1950-06-02. The remainder is `3600000` ms, or 01:00. The old result was 1950-06-02 01:00:00. `Math.floorDiv` returns `-7154`, the correct epoch day for 1950-06-01.
### How this happens in JDBC
`ArrowFlightJdbcDateVectorAccessor.getDate(Calendar)` applies the calendar offset before calling this method. A DATE starts at midnight, but any difference between the supplied calendar zone and the JVM default moves it away from midnight. Passing a `Calendar` is the documented way to read a date in a specific zone. As a result, every pre-1970 date read this way came back one day late. Any non-zero offset can expose the bug. Historical offsets can include seconds, such as +05:53:28.
The existing negative test used `-618105600000`, exactly 1950-06-01 00:00:00 UTC. At midnight, truncating division and floor division agree, so that test could not expose the bug.
The fix uses `Math.floorDiv` and `Math.floorMod` for both parts and removes the manual adjustment. Positive values behave as before. A test now covers 1950-06-01 01:00:00 UTC.
This affects `flight-sql-jdbc-core` on `main` and in 19.0.0. It is platform independent. Issues #732 and #324 cover broader timestamp and time-zone behavior. This report is only about the integer-division bug above.
コントリビューションガイド
調査の方向性
DateTimeUtils.getTimestampValue(long) から始め、次に ArrowFlightJdbcDateVectorAccessor.getDate(Calendar) と既存の負の日付のテストを調べます。カレンダーのオフセットを使って 1950-06-01 01:00:00 UTC のケースを再現し、エポック日と時刻の計算で一致する日境界が使用されていることを確認します。提供されたカレンダーを使用した 1970 年より前の日付が正しい日付を返し、回帰テストに合格すれば完了です。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- java
- 領域
- databases
- issue の種類
- バグ
- 難易度
- 2/5
- 見積もり時間
- 1〜3時間
- 活発さ
- 活発
- 明瞭さ
- 明確に書かれている
- 初心者へのやさしさ
- 84/100