[Java] Parquet DatasetFileWriter not completely emptying allocator after finishing a write
- Ngôn ngữ chính
- Java
- Star
- 94
- Fork
- 152
- Merge trung bình
- 3 ngày 16 giờ
- Pull request đã merge (30 ngày)
- 11
Mô tả
### Describe the usage question you have. Please include as many useful details as possible.
I'm currently working on a somewhat simple project that processes Parquet files as both input and output:
- Main thread is a Parquet DatasetFactory that reads the file in batches. Here I have a child **readerAllocator**.
- The main thread schedules a fixed amount of worker threads that do the actual processing. They each have their own child **workerAllocator**.
- The main thread also schedules a single writer thread that reads (via a custom ArrowReader) a queue of worker thread futures from which to obtain the new VectorSchemaRoot with additional columns. The transfer is done just fine via VectorLoader/Unloader and sent to a child **writerArrowReaderAllocator**, which is then read by the actual writer's child **writerAllocator**.
I'll admit that this is my first time using the library and am not completely up to speed with the memory management, so my first reaction to seeing the allocators as an AutoCloseable, was to use Java's try-with-resource syntax to not have to faff about with closing the allocators manually.
Much, much, much more debugging later... I realize this is a terrible idea as the allocator's behavior is not always synced with the different objects (e.g.: DatasetFileWriter) that use them (i.e.: the allocators are not empty by the time the closeable objects are closed).
I would get my output parquet file (first one at least) but then the application would exit abruptly due to closing the allocators too early as they weren't empty.
Insanity set in and I wrote this (absolutely disgusting) piece of code out of desperation (putting it at the very end after the DatasetFileWriter.write call has finished):
````java
boolean childrenEmpty = false;
while (!childrenEmpty) {
childrenEmpty = true;
for (BufferAllocator childAllocator : rootAllocator.getChildAllocators()) {
if (allocator.getAllocatorMemory <= 0) allocator.close();
else childrenEmpty = false;
}
}
````
and... finally... everything started working... no memory errors anymore...
Doing a simple test with a parquet file of 1 row, it would take the **writerAllocator** roughly anywhere from 50 to 600 iterations until the allocated memory bytes would be down to 0 and then the allocator could be closed without errors.
I'm pretty I've made mistakes in my design given that this is my first time using the library. However, in every example I've seen (whether it be from random google results, the cookbook, or even Claude Opus), the writer's allocator is handled with a try-with-resource. Heck even the [class's test](https://github.com/apache/arrow-java/blob/main/dataset/src/test/java/org/apache/arrow/dataset/file/TestDatasetFileWriter.java) closes the allocator without checking if its empty...
So I would just like to know if there is some hidden known side effect that I haven't read about or if there is some usage guidelines I simply haven't followed.
I'm also open to any alternative suggestions on how to handle the closing of the allocators.
### Component(s)
OS: RHEL 9.4
Java version: OpenJDK 26.0.1 (compiling to version 25)
Arrow JAR versions: 19.0.0
Default Memory Allocation Manager: Netty
JVM options: `--sun-misc-unsafe-memory-access=allow --add-opens=java.base/java.nio=ALL-UNNAMED`
Hướng dẫn đóng góp
Hướng nghiên cứu
Bắt đầu với dataset/src/test/java/org/apache/arrow/dataset/file/TestDatasetFileWriter.java và lời gọi DatasetFileWriter.write được mô tả trong báo cáo. Tái hiện trường hợp Parquet một hàng với writerAllocator và các allocator con của nó, sau đó theo dõi thời điểm bộ nhớ đạt đến 0 so với thời điểm đóng writer và allocator. Hoàn tất khi xác định được đây là cách sử dụng được mong đợi hay là một lỗi của thư viện, đồng thời ghi lại hướng dẫn đúng về vòng đời.
Do mô hình lập chỉ mục viết ra từ nội dung của issue.
Đánh giá
- Công nghệ
- java
- Lĩnh vực
- data
- Loại issue
- Lỗi
- Độ khó
- 4/5
- Thời gian dự kiến
- 3-5 ngày
- Mức độ hoạt động
- Ít trao đổi
- Độ rõ ràng
- Cần làm rõ
- Mức phù hợp với người mới
- 35/100