anmonteiro / anmonteiro/reason-graphql-fullstack

Suggestions

未關閉
#1 5 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
OCaml
星號
245
分支
18
PR 合併指標
30 天內沒有已合併 PR

描述

Thanks for sharing your code, @anmonteiro! 🙏It's great to have some more examples out there.

Two quick suggestions/questions:

- Could some of the usages of `io_field` be replaced with `field` to avoid `Lwt_result.return`, e.g. [this one](https://github.com/anmonteiro/reason-graphql-fullstack/blob/85dd67be8f3f4ea663f0834e5ff280a24cea618b/src/server/schema.re#L41-L47)?
- Could you use use HTTP server that ships with `graphql-lwt`, or does it lack some feature compared to the one you implemented? At a glance they seem quite similar.

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。