anmonteiro / anmonteiro/reason-graphql-fullstack

Suggestions

未关闭
#1 5 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
OCaml
星标
245
派生
18
PR 合并指标
30 天内没有已合并 PR

描述

Thanks for sharing your code, @anmonteiro! 🙏It's great to have some more examples out there.

Two quick suggestions/questions:

- Could some of the usages of `io_field` be replaced with `field` to avoid `Lwt_result.return`, e.g. [this one](https://github.com/anmonteiro/reason-graphql-fullstack/blob/85dd67be8f3f4ea663f0834e5ff280a24cea618b/src/server/schema.re#L41-L47)?
- Could you use use HTTP server that ships with `graphql-lwt`, or does it lack some feature compared to the one you implemented? At a glance they seem quite similar.

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。