anitab-org / anitab-org/mentorship-backend

Add query parameter to sort users for GET /users and GET /users/verified APIs

オープン
#420 コメント 10 件 リアクション 0 件 担当者 0 名 GitHub で見る
Category: Coding Hacktoberfest Status: Available Type: Enhancement
主要言語
Python
スター
200
フォーク
449
PR マージ指標
30日以内にマージされた PR はありません

説明

## Description

As a user of the app,
I need to have ordering capabilities,
so that I can order the users by certain attributes.

APIs used to fetch Users, don't have an option to be sorted by a certain attribute. We want to be able to filter users by name (alphabetically order) and creation date. Both should have ascending and descending order option. The idea is having a "order" parameter.

Example of order:
"name_asc" = order by name alphabetically order ascending
"name_desc" = order by name alphabetically order descending

This ^^ is just a suggestion, up for dicsussion

Please, commit your change using our [Commit message Style Guide](https://github.com/systers/mentorship-backend/wiki/Commit-Message-Style-Guide).

## Acceptance Criteria
### Update [Required]
- [ ] Add a query parameter support to GET /users, to order users by name and creation date (both ascending and descending order).
- [ ] Update Swagger UI documentation for this API.
- [ ] Write at least one test to prove your new feature is working.

## Definition of Done
- [ ] All of the required items are completed.
- [x] Approval by 1 mentor.

## Estimation
4 hours

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。