icon: Keep symbol viewBox value when register an iconSet
- Dominant language
- TypeScript
- Stars
- 25k
- Forks
- 6.8k
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 91
Description
#### Bug, feature request, or proposal:
Bug
#### What is the expected behavior?
When registering an SVG iconSet, every symbol may provide a custom `viewBox` attribute. This attribute should be keep in the newly SVG element created.
#### What is the current behavior?
The `viewBox` attribute is swallowed.
#### What are the steps to reproduce?
#### What is the use-case or motivation for changing an existing behavior?
#### Which versions of Angular, Material, OS, TypeScript, browsers are affected?
At least since beta 7
#### Is there anything else we should know?
This is related to #5188 #2981
For SVG icon set with `symbol`, see
Contributor guide
Research direction
No file or test is named in the issue. Start by tracing iconSet registration and SVG symbol creation, then verify that each symbol's custom viewBox survives in the newly created SVG element and add coverage for that behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- angular, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100