bug(cdk/drag-drop): Wrong direction of drop placeholder when moving between two different horizontal drop lists
- 主要言語
- TypeScript
- スター
- 25k
- フォーク
- 6.8k
- 平均マージ
- 1日 8時間
- マージ済み PR(30日)
- 91
説明
### Is this a regression?
- [ ] Yes, this behavior used to work in the previous version
### The previous version in which this bug was not present was
_No response_
### Description
Video: https://github.com/angular/components/assets/75433150/224b9a5c-cb45-44d4-8a94-04cae935fe65
As per the attached video and reproducible in the stackblitz, when you drag from one horizontal drop list to another, the direction reverses. For example, if you drag from a first row to a second row starting from the right and moving down to the left, once you get to the second row, the drop placeholder will show up on the right regardless of where the cursor was when you entered the second row. From here on, the directions will be reversed. If you drag to the right the drop placeholder will be seen on the left and vice versa.
Am I doing something wrong?
Edit: It seems that the problem occurs only when I change the width of the placeholder and when passing from the first droplist to the second droplist. In this case I do not land on the space intended for the drop placeholder but on another list item. The problem seems to be in the "_getItemIndexFromPointerPosition" method, where, analyzing the conditions, the case of not landing on the placeholder is not allowed. In fact, everything works fine when landing on the placeholder and then moving to the other list item since the condition "drag == this._previousSwap.drag" will result false and will allow the placeholder to be recalculated. While having a custom width of the placeholder and landing directly on the element make the previous condition to will always be true.
### Reproduction
StackBlitz link: https://stackblitz.com/edit/stackblitz-starters-aotvtz
Steps to reproduce:
1. Drag the "component2" div and go to the bottom left from the first row to the second row
2. Keep dragging and start moving to the left/right
### Expected Behavior
I expect the placeholder to show up based on where the cursor is when entering the drop list and that the direction is not reversed, like it does when dragging the "component2" div going from right to bottom right.
### Actual Behavior
The placeholder appears regardless of the cursor position when entering the droplist and the direction is reversed
### Environment
- Angular: 17.3.5
- CDK/Material: 17.3.5
- Browser(s): Chrome
- Operating System (e.g. Windows, macOS, Ubuntu): macOs
コントリビューションガイド
調査の方向性
リンクされた StackBlitz を使って問題を再現し、カスタム幅のプレースホルダーを使用して component2 を 2 つの水平ドロップリスト間でドラッグします。まず _getItemIndexFromPointerPosition を読み、2 番目のリストに入るときに以前の swap 状態がどのように処理されるかを追跡します。プレースホルダーがカーソル位置に追従し、左または右に移動したときにその方向が反転しなければ完了です。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- angular, typescript
- 領域
- frontend
- issue の種類
- バグ
- 難易度
- 3/5
- 見積もり時間
- 1〜2日
- 活発さ
- 停滞
- 明瞭さ
- おおむね明確
- 初心者へのやさしさ
- 45/100