angular / angular/components

bug(Youtube player): width not responsive

Ouverte
#28,829 9 commentaires 7 réactions 0 personnes assignées Voir sur GitHub
area: youtube-player P3
Langage dominant
TypeScript
Étoiles
25k
Forks
6.8k
Merge moyen
1 j 8 h
PR mergées (30 j)
91

Description

### Is this a regression?

- [X] Yes, this behavior used to work in the previous version

### The previous version in which this bug was not present was

I only noticed it after a couple of upgrades, so I don't know exactly.

### Description

Related: https://github.com/angular/components/issues/28489
However the workarounds that are mentioned there don't work anymore.

Setting `width="100%"` does not work as the input is transformed into a number type:
https://github.com/angular/components/blob/main/src/youtube-player/youtube-player.ts#L148

What is the solution approach to get the component to display responsively so it shows up correctly on both mobile and desktop?

### Reproduction

StackBlitz link: https://stackblitz.com/edit/angular-youtube-player-responsive-issue?file=src%2Fmain.ts
Steps to reproduce:
1. Open the StackBlitz link
2. Optionally make the preview window smaller.
3. Check the browser preview to confirm that the video is overflowing the page width.

### Expected Behavior

It shoult take the whole width of the screen

### Actual Behavior

The video overflows the with of its parent elements.

### Environment

- Angular: 17.0.1
- Browser(s): Stackblitz bundled
- Operating System (e.g. Windows, macOS, Ubuntu): online

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

Start with src/youtube-player/youtube-player.ts around line 148 and reproduce the overflow using the linked StackBlitz example. Read the related issue 28489, then verify the component uses a responsive width that fits its parent in both the smaller preview and desktop-sized view.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
angular, typescript
Domaine
frontend, web-dev
Type d'issue
Bug
Difficulté
3/5
Temps estimé
1-2 jours
Activité
À l'abandon
Clarté
Plutôt claire
Accessibilité débutants
42/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.