angular / angular/components

bug(Youtube player): width not responsive

Abierto
#28,829 9 comentarios 7 reacciones 0 asignados Ver en GitHub
area: youtube-player P3
Lenguaje dominante
TypeScript
Estrellas
25k
Forks
6.8k
Merge medio
1 d 8 h
PR fusionados (30 d)
91

Descripción

### Is this a regression?

- [X] Yes, this behavior used to work in the previous version

### The previous version in which this bug was not present was

I only noticed it after a couple of upgrades, so I don't know exactly.

### Description

Related: https://github.com/angular/components/issues/28489
However the workarounds that are mentioned there don't work anymore.

Setting `width="100%"` does not work as the input is transformed into a number type:
https://github.com/angular/components/blob/main/src/youtube-player/youtube-player.ts#L148

What is the solution approach to get the component to display responsively so it shows up correctly on both mobile and desktop?

### Reproduction

StackBlitz link: https://stackblitz.com/edit/angular-youtube-player-responsive-issue?file=src%2Fmain.ts
Steps to reproduce:
1. Open the StackBlitz link
2. Optionally make the preview window smaller.
3. Check the browser preview to confirm that the video is overflowing the page width.

### Expected Behavior

It shoult take the whole width of the screen

### Actual Behavior

The video overflows the with of its parent elements.

### Environment

- Angular: 17.0.1
- Browser(s): Stackblitz bundled
- Operating System (e.g. Windows, macOS, Ubuntu): online

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Start with src/youtube-player/youtube-player.ts around line 148 and reproduce the overflow using the linked StackBlitz example. Read the related issue 28489, then verify the component uses a responsive width that fits its parent in both the smaller preview and desktop-sized view.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
angular, typescript
Área
frontend, web-dev
Tipo de issue
Error
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
42/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.