angular / angular/components

bug(Menu): Incorrect position of submenu while using ng-template

Aperta
#26,252 3 commenti 2 reazioni 0 assegnatari Vedi su GitHub
area: material/menu P4
Lingua principale
TypeScript
Stelle
25k
Fork
6.8k
Merge medio
1g 8h
PR unite (30g)
91

Descrizione

### Is this a regression?

- [X] Yes, this behavior used to work in the previous version

### The previous version in which this bug was not present was

11.x

### Description

After some digging, I found the commit that break the positioning of the submenu when the menu items are created by using `ng-template`

The first related issue is #16167 and the corresponding [commit](https://github.com/angular/components/commit/44293522e98bbd975e5fba2551421af32631f2de) changed the way the padding is determined. Instead of using a fix value, it calculates the padding from the "offset of the first item".

Also, another issue (which is still open) #14842 clearly states that `@ContentChildren` does not find child elements created via `ngTemplateOutlet`.

These hand in hand break our code when we changed Angular version. Here is what happens:
- We have a template for "no-child menu items"
- The menu item is created by using `ngTemplateOutlet` when the menu item does not have any child element
- Otherwise, a `button[mat-menu-item]` is created directly

This causes a problem, since the `_items` collection of the menu does not contain the elements created from the `ng-template` so the calculated "padding" is totally wrong (in our case 200px instead of 8px).

A possible fix would be that instead of using the first item offset, the style of the first item's parent could be calculated using [window.getComputedStyle](https://developer.mozilla.org/en-US/docs/Web/API/Window/getComputedStyle), for example.

### Reproduction

Steps to reproduce (see [stackblitz](https://stackblitz.com/edit/components-issue-rlxajt?file=src/app/example-component.html)):

1. Open the main menu
2. Open a submenu (position is off)

The stackblitz is greatly simplified.

### Expected Behavior

The appropriate padding should be calculated so the submenu can be shown in the right place.

### Actual Behavior

The submenu is shown in the wrong place

### Environment

- Angular: 14.2.0
- CDK/Material: 14.2.0
- Browser(s): Google Chrome 108.0.5359.95
- Operating System (e.g. Windows, macOS, Ubuntu): Windows 10

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Inizia con la riproduzione collegata su StackBlitz ed esamina la logica di posizionamento del sottomenu, in particolare il calcolo del padding basato sull’offset del primo elemento e sulla raccolta `_items`. Confronta il comportamento con il commit 44293522e98bbd975e5fba2551421af32631f2de e verifica che gli elementi creati tramite `ngTemplateOutlet` producano la posizione prevista del sottomenu e un padding di 8px.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
angular, typescript
Ambito
frontend
Tipo di issue
Bug
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
35/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.