angular / angular/components

perf(cdkTextareaAutosize): Allow custom LineHeight computation strategies

Aperta
#24,211 3 commenti 6 reazioni 0 assegnatari Vedi su GitHub
area: cdk/text-field G P3
Lingua principale
TypeScript
Stelle
25k
Fork
6.8k
Merge medio
1g 8h
PR unite (30g)
91

Descrizione

### Is this a regression?

- [ ] Yes, this behavior used to work in the previous version

### The previous version in which this bug was not present was

_No response_

### Description

_cacheTextareaLineHeight() runs at startup for every instance of cdkTextareaAutosize, despite the fact that for most applications, the line height value will be consistent and constant across the whole app, and frequently known at development time.

_cacheTextareaLineHeight() is a costly operation as it triggers css layout (measured at about 20ms per textarea in my app).

For most applications, it would be safe to compute the value only once and share between instances, and many other apps could just hardcode it.

See internal CL 421826236 for more context.

### Reproduction

Steps to reproduce:
1. Bootstrap multiple textareas with cdkTextareaAutosize

### Expected Behavior

Developer is able to override default behavior of doing costly measurements of text line height on every instance

### Actual Behavior

No mechanism to override default behavior of doing costly measurements of text line height on every instance

### Environment

- Angular: 13
- CDK/Material: 13
- Browser(s): All
- Operating System (e.g. Windows, macOS, Ubuntu): All

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Start by locating cdkTextareaAutosize and its _cacheTextareaLineHeight() entry point, then trace how each instance computes and stores line height. Review any nearby tests for autosize behavior. Done means the default behavior remains covered while applications can choose a custom computation strategy that avoids unnecessary per-instance layout measurement.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
angular, typescript
Ambito
frontend, performance
Tipo di issue
Funzionalità
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
35/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.