angular / angular/components

perf(cdkTextareaAutosize): Allow custom LineHeight computation strategies

Ouverte
#24,211 3 commentaires 6 réactions 0 personnes assignées Voir sur GitHub
area: cdk/text-field G P3
Langage dominant
TypeScript
Étoiles
25k
Forks
6.8k
Merge moyen
1 j 8 h
PR mergées (30 j)
91

Description

### Is this a regression?

- [ ] Yes, this behavior used to work in the previous version

### The previous version in which this bug was not present was

_No response_

### Description

_cacheTextareaLineHeight() runs at startup for every instance of cdkTextareaAutosize, despite the fact that for most applications, the line height value will be consistent and constant across the whole app, and frequently known at development time.

_cacheTextareaLineHeight() is a costly operation as it triggers css layout (measured at about 20ms per textarea in my app).

For most applications, it would be safe to compute the value only once and share between instances, and many other apps could just hardcode it.

See internal CL 421826236 for more context.

### Reproduction

Steps to reproduce:
1. Bootstrap multiple textareas with cdkTextareaAutosize

### Expected Behavior

Developer is able to override default behavior of doing costly measurements of text line height on every instance

### Actual Behavior

No mechanism to override default behavior of doing costly measurements of text line height on every instance

### Environment

- Angular: 13
- CDK/Material: 13
- Browser(s): All
- Operating System (e.g. Windows, macOS, Ubuntu): All

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

Start by locating cdkTextareaAutosize and its _cacheTextareaLineHeight() entry point, then trace how each instance computes and stores line height. Review any nearby tests for autosize behavior. Done means the default behavior remains covered while applications can choose a custom computation strategy that avoids unnecessary per-instance layout measurement.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
angular, typescript
Domaine
frontend, performance
Type d'issue
Fonctionnalité
Difficulté
4/5
Temps estimé
3-5 jours
Activité
À l'abandon
Clarté
Plutôt claire
Accessibilité débutants
35/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.