angular / angular/components

feat(dialog): Dialogs can define the type for their dialog data

オープン
#23,985 コメント 5 件 リアクション 22 件 担当者 0 名 GitHub で見る
area: material/dialog feature needs: discussion P3
主要言語
TypeScript
スター
25k
フォーク
6.8k
平均マージ
1日 8時間
マージ済み PR(30日)
91

説明

### Feature Description

#4398 introduced a generic type argument for `MatDialogConfig`. This type argument is forwarded in `open`. However, the type is never tied in anyway to the actual component, making the type argument an essentially useless type assertion.

While due to the nature of Angular's dependency injection full type-safety cannot be achieved, it would be nice if at least the dialog component could declare the type it receives itself in such a way that a call to `open` will infer the correct type automatically. In order to achieve this, the dialog component needs to somehow expose this information. Here are a few possible solutions in no particular order, though others might exist:

#### Interface with type inference

We could define an interface and a helper type as follows:

```
interface MatDialogHasData {
data: T;
}

type ExtractDialogDataType = T extends MatDialogHasData ? D : any;
```

We can then adjust the type signature of `open` to infer the type accordingly:

```
open(
component: ComponentType,
data?: MatDialogConfig>
): MatDialogReg
```

Finally, a dialog component would be required to have a public field named `data` of the according type, which would typically be achieved through the injection itself:

```
constructor(@Inject(MAT_DIALOG_DATA) public data: MyDialogDataType) {}
```

*Note*: This change _is_ breaking because the generic signature of `open` changes and because dialog components could have an unrelated `data` field which would lead to an unintended type inference. Unfortunately we cannot prevent this here due to TypeScript's structural typing nature. In particular users would no longer be able to manually define the generic type argument. However see further below for a solution to this problem.

#### Interface with explicit method

Instead, we could also introduce an interface with an explicit method to be implemented:

```
interface MatDialogHasData {
getDialogData(): T
}
```

Otherwise the approach is largely similar. This change is only breaking in the generic type signature (I'm not sure whether you count this as a breaking change), however we could actually avoid that by changing our helper type to

```
type ExtractDialogDataType = T extends MatDialogHasData ? D : FALLBACK;
```

and then using the type argument as a fallback:

```
open(
component: ComponentType,
data?: MatDialogConfig>
): MatDialogReg
```

*Note*: The same could be done in the solution above. I believe we could make this a completely backwards-compatible change, excluding of course the exotic situation that a component happens to already have a `getDialogData` method for unrelated reasons. The only disadvantage here is forcing the component to provide a public method. In practice I don't consider this a concern as Angular already forces us to make many things public that shouldn't be public from a component API perspective.

---

On a very similar note, it would be nice to have the same for the inferred result type `R`, i.e. the component being able to define the type of data it can return, and have this information flow through the `open` method to the caller. The approaches mentioned above could, in theory, cover this as well.

### Use Case

Given some `MyDialogComponent` which expects dialog data of type `MyDialogData`, I would like

```
open(MyDialogComponent, {
data: {
// …
}
});
```

to type-check `data` against `MyDialogData` without having to manually specify `open`'s type arguments, but rather have this information flow from `MyDialogComponent`.

コントリビューションガイド

コントリビューションガイドを開く

調査の方向性

まず、issue で説明されている MatDialogConfig と open の型シグネチャ、および提案されている MatDialogHasData と結果型のアプローチを確認します。ダイアログコンポーネントが入力データ型を宣言でき、open(MyDialogComponent, { data: ... }) が型チェックされ、手動の型引数なしでその型を推論できれば完了です。

索引モデルが issue の本文から書いたものです。

評価

技術スタック
angular, typescript
領域
frontend
issue の種類
機能追加
難易度
5/5
見積もり時間
1週間以上
活発さ
停滞
明瞭さ
おおむね明確
初心者へのやさしさ
35/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。