angular / angular/components

Relax MatTableDataSource’s filter to be of type “{}”

未关闭
#16,112 8 条评论 6 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

area: material/table feature P3
主要语言
TypeScript
星标
25k
派生
6.8k
平均合并
1 天 8 小时
30 天内合并 PR
91

描述

Feature Description

Relax MatTableDataSource.filter to accept {}. Right now, it is restricted to string.
This would allow much easier custom filtering on multiple dimensions.

Use Case

When the filter is “only” a string, it makes it very difficult to “structurally” filter a table on multiple dimensions, even when customizing filterPredicate . Some recommendations on internet include:

While it works, it’s also a gratuitous workaround: It turns out that at no point does MatTableDataSource actually require filter to be a string: Whatever gets passed to filter just gets piped “as-is” to filterPredicate.

Here is a simple fork of “Table with filtering” that filters on different columns individually, where all I did was pass my complex object, while not respecting :
https://stackblitz.com/edit/table-filtering-multiple-filters-example?file=app/table-filtering-example.html
https://table-filtering-multiple-filters-example.stackblitz.io/

Caveats

It would still be up to the caller to make sure that their filter object is homogeneous with their filterPredicate object.

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

从 MatTableDataSource.filter 入口点开始,检查其值是如何传递给 filterPredicate 的。更新公共类型以接受 {},同时保留现有的 predicate 流程,然后验证结构化的多维过滤器对象无需进行 JSON 转换即可工作。

由索引模型根据 Issue 内容生成。

评估

技术栈
angular, typescript
领域
frontend
Issue 类型
功能
难度
2/5
预计耗时
1-3 小时
活跃度
停滞
描述清晰度
描述清楚
新手友好度
45/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。