Use of custom TrackByFunction in MatTree does not preserve expansion state when nodes change
- 主要言語
- TypeScript
- スター
- 25k
- フォーク
- 6.8k
- 平均マージ
- 1日 8時間
- マージ済み PR(30日)
- 91
説明
#### What is the expected behavior?
Use of trackBy should also ensure that the expansion state does not get lost when nodes are updated.
#### What is the current behavior?
Use of trackBy does not ensure that the expansion state does not get lost when nodes are updated. This is presumably since TreeControl uses an expansionModel which is a SelectionModel where the SelectionModel has no awareness of the TrackByFunction.
#### What are the steps to reproduce?
Relying upon the TreeControl expansionModel:
https://stackblitz.com/edit/angular-5wpr9o-kjnmsn?file=app%2Ftree-flat-overview-example.ts
#### Which versions of Angular, Material, OS, TypeScript, browsers are affected?
all
#### Is there anything else we should know?
Trying to store expansion state in the nodes themselves as a workaround doesn't work (unless you transfer the state):
https://stackblitz.com/edit/angular-5wpr9o-ahptjs?file=app%2Ftree-flat-overview-example.ts
Having a custom expansionModel that is aware of the trackBy state works to preserve state, since the TreeControl's expansion-related methods apparently aren't actually used internally by the tree component:
https://stackblitz.com/edit/angular-5wpr9o-pbmk1g?file=app%2Ftree-flat-overview-example.ts
コントリビューションガイド
調査の方向性
リンクされた StackBlitz の再現例、特に app/tree-flat-overview-example.ts から始め、MatTree、TreeControl、TrackByFunction、expansionModel がどのように相互作用するかを調べます。カスタム trackBy を使用してノードを更新したときに展開状態が失われることを再現します。これらの更新後も展開状態が保持されれば完了です。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- angular, typescript
- 領域
- frontend
- issue の種類
- バグ
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 活発さ
- 停滞
- 明瞭さ
- おおむね明確
- 初心者へのやさしさ
- 38/100