angular / angular/components

[Docs] More details on custom form field controls guide

未关闭
#13,624 6 条评论 2 个 reaction 已指派 0 人 在 GitHub 查看
area: docs area: material/form-field help wanted P3
主要语言
TypeScript
星标
25k
派生
6.8k
平均合并
1 天 8 小时
30 天内合并 PR
91

描述

#### Bug, feature request, or proposal:
I'd like to request a review of the 'Creating a custom form field control' guide as it does not cover enough in regards to each of it properties and opts to just mentioning them.

#### What is the expected behaviour?
Common examples that are detailed on other approaches and usages.

#### What is the current behaviour?
Common examples that are not all detailed on other approaches or usages.

#### What is the use-case or motivation for changing an existing behaviour?
My biggest gripe that pushed me to make this ticket is that of the error state.

> Since we're not using an NgControl in this example, we don't need to do anything other than just set it to false.

Where as it should be like 'ngControl' which has sufficient methods of implementation

> It is likely you will want to implement ControlValueAccessor ...

#### Is there anything else we should know?
Others have had the same issue

https://stackoverflow.com/questions/52017000/angular-material-custom-reactive-form-control-with-error-state/52017769

贡献指南

打开贡献指南

调研方向

首先阅读“Creating a custom form field control”指南,并将其中的属性说明与所要求的示例和错误状态讨论进行比较。完成标准是:指南解释常见的属性用法,展示相关方法,并阐明错误状态处理和 ControlValueAccessor 上下文。

由索引模型根据 Issue 内容生成。

评估

技术栈
angular, typescript
领域
documentation
Issue 类型
文档
难度
3/5
预计耗时
1-2 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
35/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。