[Docs] More details on custom form field controls guide
- Lenguaje dominante
- TypeScript
- Estrellas
- 25k
- Forks
- 6.8k
- Merge medio
- 1 d 8 h
- PR fusionados (30 d)
- 91
Descripción
#### Bug, feature request, or proposal:
I'd like to request a review of the 'Creating a custom form field control' guide as it does not cover enough in regards to each of it properties and opts to just mentioning them.
#### What is the expected behaviour?
Common examples that are detailed on other approaches and usages.
#### What is the current behaviour?
Common examples that are not all detailed on other approaches or usages.
#### What is the use-case or motivation for changing an existing behaviour?
My biggest gripe that pushed me to make this ticket is that of the error state.
> Since we're not using an NgControl in this example, we don't need to do anything other than just set it to false.
Where as it should be like 'ngControl' which has sufficient methods of implementation
> It is likely you will want to implement ControlValueAccessor ...
#### Is there anything else we should know?
Others have had the same issue
https://stackoverflow.com/questions/52017000/angular-material-custom-reactive-form-control-with-error-state/52017769
Guía de contribución
Línea de trabajo
Comienza leyendo la guía «Creating a custom form field control» y compara las descripciones de sus propiedades con los ejemplos solicitados y la discusión sobre el estado de error. Se considera terminado cuando la guía explica los usos habituales de las propiedades, muestra enfoques relevantes y aclara la gestión del estado de error y el contexto de ControlValueAccessor.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- angular, typescript
- Área
- documentation
- Tipo de issue
- Documentación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 35/100