angular / angular/components

[Docs] More details on custom form field controls guide

Open
#13,624 6 comments 2 reactions 0 assignees View on GitHub
area: docs area: material/form-field help wanted P3
Dominant language
TypeScript
Stars
25k
Forks
6.8k
Avg merge
1d 8h
Merged PRs (30d)
91

Description

#### Bug, feature request, or proposal:
I'd like to request a review of the 'Creating a custom form field control' guide as it does not cover enough in regards to each of it properties and opts to just mentioning them.

#### What is the expected behaviour?
Common examples that are detailed on other approaches and usages.

#### What is the current behaviour?
Common examples that are not all detailed on other approaches or usages.

#### What is the use-case or motivation for changing an existing behaviour?
My biggest gripe that pushed me to make this ticket is that of the error state.

> Since we're not using an NgControl in this example, we don't need to do anything other than just set it to false.

Where as it should be like 'ngControl' which has sufficient methods of implementation

> It is likely you will want to implement ControlValueAccessor ...

#### Is there anything else we should know?
Others have had the same issue

https://stackoverflow.com/questions/52017000/angular-material-custom-reactive-form-control-with-error-state/52017769

Contributor guide

Open the contributing guide

Research direction

Start by reading the “Creating a custom form field control” guide and compare its property descriptions with the requested examples and error-state discussion. Done means the guide explains common property usages, shows relevant approaches, and clarifies error-state handling and ControlValueAccessor context.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, typescript
Domain
documentation
Issue type
Documentation
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.