mat-form-field required fields that are disabled should have the option to show the asterisk
- 主要言語
- TypeScript
- スター
- 25k
- フォーク
- 6.8k
- 平均マージ
- 1日 8時間
- マージ済み PR(30日)
- 91
説明
#### Bug, feature request, or proposal:
Proposal
#### What is the expected behavior?
For a control that is required and disabled the asterisk has the option to be shown.
#### What is the current behavior?
When a control is disabled the asterisk is removed, even when marked as required. This will show a form as requiring less fields to be populated than actually is required.
#### What are the steps to reproduce?
Providing a StackBlitz reproduction is the *best* way to share your issue.
StackBlitz starter: https://goo.gl/wwnhMV
https://stackblitz.com/edit/angular-material2-issue-sezut1?file=app/app.component.ts
#### What is the use-case or motivation for changing an existing behavior?
We have a form that requires you to choose a hierarchy location first - which will then go off and get related data. The selects are required but disabled to start with because they can't be interacted with until the hierarchy location is selected. Once hierarchy location is selected, selects get populated and become enabled.
The issue here is the drip-feeding, the user will be shown X controls on load that are required - as the user is actively filling in the form they will be told more controls are required. So the initial X controls that were required is now incorrect and now more controls are required to be populated.
#### Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular 5.2.2. Material 5.1.0
#### Is there anything else we should know?
I found where this change was done, in request to robmv's proposal (https://github.com/angular/material2/issues/8251). I believe there is a valid use-case where asterisk's should not be shown, but in our use-case we need to show the asterisk even when disabled.
コントリビューションガイド
調査の方向性
リンクされた StackBlitz で再現されている mat-form-field の動作、特に app/app.component.ts から始めて、必須の無効化されたコントロールがどのように表現されているかを確認します。既存の動作をデフォルトで維持しながら、アスタリスクを保持するためのオプションをどのように公開するかを決定します。そのオプションを有効にしたときに、再現で無効化されたコントロールの必須マーカーが表示されれば完了です。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- angular, typescript
- 領域
- frontend
- issue の種類
- 機能追加
- 難易度
- 3/5
- 見積もり時間
- 1〜2日
- 活発さ
- 停滞
- 明瞭さ
- おおむね明確
- 初心者へのやさしさ
- 35/100