angular / angular/angularfire

Deployment to Google Cloud Run using Angular v17 Application Builder not working

Aperta
#3,502 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
TypeScript
Stelle
7.8k
Fork
2.2k
Merge medio
22h 28m
PR unite (30g)
6

Descrizione

### Version info

**Angular:**
17.2.2
**Firebase:**
13.3.1
**AngularFire:**
17.0.1
**Other (e.g. Ionic/Cordova, Node, browser, operating system):**
Node 20
### How to reproduce these conditions
Use `@angular/fire` with the new `@angular-devkit/build-angular:application`.
**Failing test unit, Stackblitz demonstrating the problem**

**Steps to set up and reproduce**
Start a new repo with the following configuration (I used Nx with `project.json`, but vanilla `angular.json` also works):
```json
// ...
"targets": {
"build": {
"executor": "@angular-devkit/build-angular:application",
"outputs": ["{options.outputPath}"],
"options": {
"outputPath": "dist/apps/app",
}
}
"deploy": {
"executor": "@angular/fire:deploy",
"configurations": {
"production": {
"buildTarget": "app:build:production",
"serveTarget": "app:build:production"
}
},
}
```

Then execute the target using `npx nx run app:build --configuration=production`. This creates the following structre:
```txt
dist/
|_ apps/
|_ app/
|_ browser/
|_ server/
|_ ...
|_ main.server.mjs
|_ server.mjs
```

But [this code to deploy to Cloud Run](https://github.com/angular/angularfire/blob/73b40da11f7f56884c86da9cbe1123f3d00bc866/src/schematics/deploy/actions.ts#L318) still uses the old `main.js`. Also, it is using the `outputPath` from the `build` target, but since that `outputPath` does not contain `browser` or `server`, the final path needs to have this folder added too.

The change can be something like this (I have not tested this):
```ts
const packageJson = getPackageJson(context, workspaceRoot, options, join(serverBuildOptions.outputPath, 'main.js'));
```
...to something like this:
```ts
const packageJson = getPackageJson(context, workspaceRoot, options, join(serverBuildOptions.outputPath, 'server', 'main.server.mjs'));
```
...and probably more than this.

**Sample data and security rules**

### Debug output

** Errors in the JavaScript console **

** Output from `firebase.database().enableLogging(true);` **

** Screenshots **

### Expected behavior

Upload to Cloud Run using Angular v17 `@angular-devkit/build-angular:application` should work.

### Actual behavior

Upload to Cloud Run fails for Angular v17 with `@angular-devkit/build-angular:application`.

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Inizia eseguendo `npx nx run app:build --configuration=production` e ispeziona `src/schematics/deploy/actions.ts` intorno al codice di deployment Cloud Run collegato nell'issue. Confronta l'output `dist/.../browser` e `server` dell'Angular application builder con i percorsi utilizzati per il deployment, quindi verifica che il deployment abbia esito positivo per questa configurazione.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
angular, firebase, google-cloud, typescript
Ambito
build-system, cloud, devops
Tipo di issue
Bug
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
35/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.