Deployment to Google Cloud Run using Angular v17 Application Builder not working
- Dominant language
- TypeScript
- Stars
- 7.8k
- Forks
- 2.2k
- Avg merge
- 22h 28m
- Merged PRs (30d)
- 6
Description
### Version info
**Angular:**
17.2.2
**Firebase:**
13.3.1
**AngularFire:**
17.0.1
**Other (e.g. Ionic/Cordova, Node, browser, operating system):**
Node 20
### How to reproduce these conditions
Use `@angular/fire` with the new `@angular-devkit/build-angular:application`.
**Failing test unit, Stackblitz demonstrating the problem**
**Steps to set up and reproduce**
Start a new repo with the following configuration (I used Nx with `project.json`, but vanilla `angular.json` also works):
```json
// ...
"targets": {
"build": {
"executor": "@angular-devkit/build-angular:application",
"outputs": ["{options.outputPath}"],
"options": {
"outputPath": "dist/apps/app",
}
}
"deploy": {
"executor": "@angular/fire:deploy",
"configurations": {
"production": {
"buildTarget": "app:build:production",
"serveTarget": "app:build:production"
}
},
}
```
Then execute the target using `npx nx run app:build --configuration=production`. This creates the following structre:
```txt
dist/
|_ apps/
|_ app/
|_ browser/
|_ server/
|_ ...
|_ main.server.mjs
|_ server.mjs
```
But [this code to deploy to Cloud Run](https://github.com/angular/angularfire/blob/73b40da11f7f56884c86da9cbe1123f3d00bc866/src/schematics/deploy/actions.ts#L318) still uses the old `main.js`. Also, it is using the `outputPath` from the `build` target, but since that `outputPath` does not contain `browser` or `server`, the final path needs to have this folder added too.
The change can be something like this (I have not tested this):
```ts
const packageJson = getPackageJson(context, workspaceRoot, options, join(serverBuildOptions.outputPath, 'main.js'));
```
...to something like this:
```ts
const packageJson = getPackageJson(context, workspaceRoot, options, join(serverBuildOptions.outputPath, 'server', 'main.server.mjs'));
```
...and probably more than this.
**Sample data and security rules**
### Debug output
** Errors in the JavaScript console **
** Output from `firebase.database().enableLogging(true);` **
** Screenshots **
### Expected behavior
Upload to Cloud Run using Angular v17 `@angular-devkit/build-angular:application` should work.
### Actual behavior
Upload to Cloud Run fails for Angular v17 with `@angular-devkit/build-angular:application`.
Contributor guide
Research direction
Start by running `npx nx run app:build --configuration=production` and inspect `src/schematics/deploy/actions.ts` around the Cloud Run deployment code linked in the issue. Compare the Angular application builder's `dist/.../browser` and `server` output with the paths used by deployment, then verify that deployment succeeds for this configuration.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- angular, firebase, google-cloud, typescript
- Domain
- build-system, cloud, devops
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100