angular / angular/angular-cli

Check pathnames for illegal characters (e.g. outputPath for build files)

未關閉
#19,533 2 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
area: @angular-devkit/build-angular feature feature: insufficient votes
主要語言
TypeScript
星號
27k
分支
11.8k
平均合併
14 小時 23 分鐘
30 天內合併 PR
162

描述

# 🐞 Bug report

### Command (mark with an `x`)

- [ ] new
- [x] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] extract-i18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

### Description

The Angular CLI should warn the user if a specified path is invalid for the current system.

I accidently set `".../dist"` (three dots) as `outputPath` in `angular.json`. Correct is `"../dist"` (two dots). Running `ng build` created a huge mess. In the app root a folder has been created with `...` as name (ending a folder name in Windows with a dot is illegal). Inside of this three dot folder all of my project files were listed (including `node_modules` folder). There was also a folder named `...`, which again contained my whole project files. This recursively went to whatever level (I clicked throuhg the folder approximately 30 levels down, there was still a `...` folder). Deleting the first `...` folder lastet more than 15 minutes, then telling me the files which should be deleted aren't there anymore. Also my project files in the root directory were deleted in this process (luckily most of it in Git). That was the strangest thing, it felt like the content inside of `...` mirrored my root project somehow (like in https://superuser.com/questions/528502/cant-remove-three-dots-folder-on-my-hdd). I also tried reverting my files using Git which did not work at all. I managed to delete the whole repository locally with `rm -rf 'folder'` using the GitBash. After cloning the project again, my IDE (Webstorm) listed the `...` folder once again, which luckily could be deleted this time. The project looks fine right now, and with the correct `outputPath` the app builds correctly.

It would be nice if the CLI checks pathnames for illegal characters. I did not try any other illegal characters inside of the path name.

## 🔬 Minimal Reproduction

Caution: Try in a sandbox environment with unimported files only to prevent loss of data!

1. Change the `"outputPath"` in `angular.json` to `".../dist"` (three dots)
2. Run `ng build`

## 🌍 Your Environment

Angular CLI: 11.0.1
Node: 14.15.0
OS: win32 x64

Angular: 11.0.0
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router
Ivy Workspace: Yes

Package Version
---------------------------------------------------------
@angular-devkit/architect 0.1100.1
@angular-devkit/build-angular 0.1100.1
@angular-devkit/core 11.0.1
@angular-devkit/schematics 11.0.1
@angular/cdk 11.0.1
@angular/cli 11.0.1
@angular/material 11.0.1
@schematics/angular 11.0.1
@schematics/update 0.1100.1
rxjs 6.6.3
typescript 4.0.5

**Anything else relevant?**

![ng build gone wrong](https://user-images.githubusercontent.com/41572666/100902827-8fc22880-34c5-11eb-8f4e-30f2bdfde031.png)

貢獻指南

開啟貢獻指南

研究方向

首先,在 Windows 沙盒中使用 issue 中描述的 `angular.json` 設定,重現將 `outputPath` 設為 `.../dist` 的 `ng build` 指令。追蹤建置如何處理該路徑,並驗證無效的路徑名稱會在建立檔案或目錄之前產生警告或錯誤。

由索引模型根據 Issue 內容生成。

評估

技術堆疊
angular, typescript
領域
build-system, cli
Issue 類型
缺陷
難度
3/5
預估耗時
1-2 天
活躍度
停滯
描述清晰度
描述清楚
新手友好度
35/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。