angr / angr/cle

Wrong lookups for DWARF v5 filename

Aperta
#548 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
bug
Lingua principale
Python
Stelle
485
Fork
135
Merge medio
2g 2h
PR unite (30g)
15

Descrizione

### Description

I think I've found a bug in (edit 1/20/25: ~~pyelftools/examples/dwarf_decode_address.py~~) https://github.com/angr/cle/blob/master/cle/backends/elf/elf.py that leads to wrong filenames retrievals from DWARF v5 data.
I believe the "- 1" here:

`line 668: file_entry = lineprog.header["file_entry"][line.state.file - 1]`

should be a "- 0" when processing DWARF v5. (In the example I was looking at, the index became -1, which wrapped around to the last entry, giving a wrong filename.)

cle uses pyelftools. Here's an example directly from the pyelftools repo that gives me the answer I expect: https://github.com/eliben/pyelftools/blob/main/examples/dwarf_decode_address.py

From that example, here's the difference in logic from the cle implementation:
```
line 83: delta = 1 if lineprog.header.version < 5 else 0
line 92: filename = lineprog['file_entry'][prevstate.file - delta].name
```

### Steps to reproduce the bug

_No response_

### Environment

_No response_

### Additional context

_No response_

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.