angr / angr/cle

Wrong lookups for DWARF v5 filename

Offen
#548 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
bug
Vorherrschende Sprache
Python
Sterne
485
Forks
135
Ø Merge
2 T. 2 Std.
Gemergte PRs (30 T.)
15

Beschreibung

### Description

I think I've found a bug in (edit 1/20/25: ~~pyelftools/examples/dwarf_decode_address.py~~) https://github.com/angr/cle/blob/master/cle/backends/elf/elf.py that leads to wrong filenames retrievals from DWARF v5 data.
I believe the "- 1" here:

`line 668: file_entry = lineprog.header["file_entry"][line.state.file - 1]`

should be a "- 0" when processing DWARF v5. (In the example I was looking at, the index became -1, which wrapped around to the last entry, giving a wrong filename.)

cle uses pyelftools. Here's an example directly from the pyelftools repo that gives me the answer I expect: https://github.com/eliben/pyelftools/blob/main/examples/dwarf_decode_address.py

From that example, here's the difference in logic from the cle implementation:
```
line 83: delta = 1 if lineprog.header.version < 5 else 0
line 92: filename = lineprog['file_entry'][prevstate.file - delta].name
```

### Steps to reproduce the bug

_No response_

### Environment

_No response_

### Additional context

_No response_

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.