andywer / andywer/webpack-blocks

Using assets package with webpack 4 and babel7

未關閉
#280 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
JavaScript
星號
3k
分支
91
PR 合併指標
30 天內沒有已合併 PR

描述

Hey,
this is probably not a real issue, but I would like to share this case if anyone struggles with the same problem.
I'm using webpack 4.9.1 in my project with latest babel7 and I've run into an issue with Assets package while using `file()` in combination with `match()` when using 1.0.0 of webpack blocks. The package uses probably outdated version of file-loader dependency (0.11.2). Forcing resolutions in my package.json to use latest version of file-loader (1.11.1) removed an issue `Cannot read property 'fileLoader' of undefined` with setup like that:

```
const { createConfig, match } = require('@webpack-blocks/webpack');
const { css, url, file } = require('@webpack-blocks/assets');
const babel = require('@webpack-blocks/babel');
....
....
createConfig([
babel(),
match(['*.css'], [
css()
]),
match(['*.svg'], [
file()
]),
])
...
```

The case is, that you load a CSS file, which contains classes that have property e.g. `background-image:url(../icons/checkmark.svg`. Without the `match()` and `file()` it cant handle such files as the webpack tries to handle the source of the svg itself.

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。