andywer / andywer/webpack-blocks

Using assets package with webpack 4 and babel7

オープン
#280 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る
主要言語
JavaScript
スター
3k
フォーク
91
PR マージ指標
30日以内にマージされた PR はありません

説明

Hey,
this is probably not a real issue, but I would like to share this case if anyone struggles with the same problem.
I'm using webpack 4.9.1 in my project with latest babel7 and I've run into an issue with Assets package while using `file()` in combination with `match()` when using 1.0.0 of webpack blocks. The package uses probably outdated version of file-loader dependency (0.11.2). Forcing resolutions in my package.json to use latest version of file-loader (1.11.1) removed an issue `Cannot read property 'fileLoader' of undefined` with setup like that:

```
const { createConfig, match } = require('@webpack-blocks/webpack');
const { css, url, file } = require('@webpack-blocks/assets');
const babel = require('@webpack-blocks/babel');
....
....
createConfig([
babel(),
match(['*.css'], [
css()
]),
match(['*.svg'], [
file()
]),
])
...
```

The case is, that you load a CSS file, which contains classes that have property e.g. `background-image:url(../icons/checkmark.svg`. Without the `match()` and `file()` it cant handle such files as the webpack tries to handle the source of the svg itself.

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。