andywer / andywer/threads.js

Support spawning threads from electron ASAR file

Abierto
#425 1 comentario 3 reacciones 0 asignados Ver en GitHub
bug
Lenguaje dominante
TypeScript
Estrellas
3.5k
Forks
173
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

In pull request [226](https://github.com/andywer/threads.js/pull/226) you added code that modifies paths containing the string `.asar` because worker files could only be used if they were not packaged in an ASAR file.

In the meantime, the electron team [added support](https://github.com/electron/electron/pull/33216) for working with workers bundled in ASAR files. However, the patch in [226](https://github.com/andywer/threads.js/pull/226) does not allow us to bundle worker scripts because the path is always rewritten to point to the unpacked directory.

Can we add an option to bypass any modifications to the `scriptPath` argument? Thank you for your time.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.