andywer / andywer/threads.js

Support spawning threads from electron ASAR file

Open
#425 1 comment 3 reactions 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
3.5k
Forks
173
PR merge metrics
No merged PRs in 30d

Description

In pull request [226](https://github.com/andywer/threads.js/pull/226) you added code that modifies paths containing the string `.asar` because worker files could only be used if they were not packaged in an ASAR file.

In the meantime, the electron team [added support](https://github.com/electron/electron/pull/33216) for working with workers bundled in ASAR files. However, the patch in [226](https://github.com/andywer/threads.js/pull/226) does not allow us to bundle worker scripts because the path is always rewritten to point to the unpacked directory.

Can we add an option to bypass any modifications to the `scriptPath` argument? Thank you for your time.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.